chore(clients): remove direct dependency on client-sts #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
remove-client-sts-deps
branch
from
76de879 to
e599fb3
Compare
siddsriv
approved these changes
Apr 25, 2024
3 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Noticed while working on #6027
The clients required direct dependency on client-sts earlier, since they imported
decorateDefaultCredentialProvider.This is no longer required, since the import was removed in #5681
The utilities in client-sts are now imported from individual credential providers:
aws-sdk-js-v3/packages/credential-providers/src/loadSts.ts
Line 1 in fbf8638
aws-sdk-js-v3/packages/credential-provider-web-identity/src/loadSts.ts
Line 1 in fbf8638
Description
Removes redundant direct dependency on client-sts from all clients
Testing
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.